Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extending a functionality to count a number of requests #9

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

kupermind
Copy link
Collaborator

  • Extending a functionality to count a number of requests.

@kupermind kupermind requested review from dvilelaf and 77ph and removed request for dvilelaf October 11, 2023 12:45
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a deployment script as well to update existing deployment with this new functionality

@kupermind
Copy link
Collaborator Author

@DavidMinarsch please note (added the text to the deployment README as well) that the workflow needs to update the AgentFactory and change it as a new manager at the AgentRegistry contract. The AgentMech contract must not be deployed separately as it is created by the AgentFactory contract when creating a new mech.

Comment on lines -78 to +81
apiURL: "https://blockscout.com/gnosis/chiado/api",
browserURL: "https://blockscout.com/gnosis/chiado",
apiURL: "https://gnosis-chiado.blockscout.com/api",
browserURL: "https://gnosis-chiado.blockscout.com/",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change to updated chiado links

Comment on lines -103 to +109
version: "0.8.19",
version: "0.8.21",
settings: {
optimizer: {
enabled: true,
runs: 750,
runs: 1000000,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped the compiler version and the number of optimizations.

{"contractVerification":true,"useLedger":true,"derivationPath":"m/44'/60'/2'/0/0","providerName":"gnosis","gasPriceInGwei":"5","baseURI":"https://gateway.autonolas.tech/ipfs/","agentRegistryName":"AI Agent Registry","agentRegistrySymbol":"AI-AGENT-V1","agentRegistryAddress":"0xE49CB081e8d96920C38aA7AB90cb0294ab4Bc8EA","agentFactoryAddress":"0x88DE734655184a09B70700aE4F72364d1ad23728","agentId":"1","price":"1000000000000000000"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agentId and price are given for mech verification purposes only (e_check_04_agent_mech.js).

Comment on lines +3 to +6
const { ethers } = require("hardhat");
const { LedgerSigner } = require("@anders-t/ethers-ledger");

async function main() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is for testing purposes only to verify that the agent mech creation works without issues.

@DavidMinarsch
Copy link
Contributor

@DavidMinarsch please note (added the text to the deployment README as well) that the workflow needs to update the AgentFactory and change it as a new manager at the AgentRegistry contract. The AgentMech contract must not be deployed separately as it is created by the AgentFactory contract when creating a new mech.

Yes I'm aware. Where is the update procedure documented?

@kupermind
Copy link
Collaborator Author

@DavidMinarsch please note (added the text to the deployment README as well) that the workflow needs to update the AgentFactory and change it as a new manager at the AgentRegistry contract. The AgentMech contract must not be deployed separately as it is created by the AgentFactory contract when creating a new mech.

Yes I'm aware. Where is the update procedure documented?

I've updated the main and deployment README-s

@kupermind kupermind merged commit 1f3c44b into main Oct 13, 2023
@kupermind kupermind deleted the requests_count branch October 13, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants